D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added a comment. Given the other reviews (which just drop this function), this one should be abandoned. tcberner@? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov,

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

bruns added a comment. See D12136 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

bruns added a comment. In D5784#243432 , @adridg wrote: > The question is mostly: does the existing (complicated) code do anything that QStorageInfo doesn't? Because switching to QStorageInfo gives us the functionality on FreeBSD for free (even i

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added a comment. The question is mostly: does the existing (complicated) code do anything that QStorageInfo doesn't? Because switching to QStorageInfo gives us the functionality on FreeBSD for free (even if it's not useful because we'll never have btrfs). REPOSITORY R293 Baloo REV

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk resigned from this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

bruns added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, kfunk, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

bruns added a comment. Restricted Application added a project: Baloo. The whole function as currently used is pointless. Currently, it sets the NO_COW flag on BTRFS, but this is insufficient: - XFS - https://lwn.net/Articles/747633/ - F2FS - Hammer2 ? At least on Linux, the c

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added reviewers: kfunk, poboiko. adridg added a comment. Add reviewers who have commented, or who have committed to baloo recently. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, kfunk, poboiko Cc: adridg, kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

adridg added a comment. So this patch looks ready to land to me: it simplifies the code, defers fstype-detection to QStorageInfo (for FreeBSD, we should fix the original issue there), and is otherwise non-intrusive. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner updated this revision to Diff 14965. tcberner added a comment. Use QStorageInfo. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5784?vs=14334&id=14965 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5784 AFFECTED FILES src/engine/

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner added a comment. Ok, I think I found the issue in QStorageInfo -- it calls getmntinfo() with `flags=0` [1] . Instead one of the valid arguments 1-4 [2]. [1] https://github.com/qt/qtbase/blob/dev/src/corelib/io/qstorageinfo_unix.cpp#L199 [2] https://svnweb.freebsd.org/base/hea

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner planned changes to this revision. tcberner added a comment. I agree. I'll try and figure out whats wrong inside QStorageInfo, and then update the review here to be using it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd Cc: kfunk

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk added a comment. Okay, then maybe support for the current FreeBSD version is not implemented? I have no idea about FreeBSD, to be honest. But it looks like using this API, and implementing the proper support in `QStorageInfo` internals would be the appropriate place. Anyhow, if Qt

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner added a comment. Hm, QStorageInfo does not seem to return anything sensible on FreeBSD: "" name: "" fileSystemType: "" size: 0 MB availableSize: 0 MB This is the output from the `QStorageInfo::root()` example. REPOSITORY R293 Baloo REVISION DETAIL http

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk added a comment. What about http://doc.qt.io/qt-5/qstorageinfo.html#fileSystemType? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd Cc: kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is not really needed at the moment, as it only seems to be needed to check if the filesystem is btrfs. I'm however not sure, if t