This revision was automatically updated to reflect the committed changes.
Closed by commit R289:0d2f45ed3033: Use application name instead of pid when
creating SNI dbus service (authored by jgrulich).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5783?
jgrulich added a comment.
Using applicationName-pid you cannot guarantee the pid will be always 1 or 2,
you can have e.g a special launcher for an app doing some stuff and then you
end up with much higher pid.
REPOSITORY
R289 KNotifications
BRANCH
application-dbus (branched from master)
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
definitely better!
i don't know whether we can afford to change it in any way outside the sanbox
and not break things..
it may make sense to use applicationName-pid at least inside the sandb
jgrulich updated this revision to Diff 14361.
jgrulich added a comment.
Remove my useless debug
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5783?vs=14360&id=14361
BRANCH
application-dbus (branched from master)
REVISION DETAIL
https://phabric
jgrulich updated this revision to Diff 14360.
jgrulich added a comment.
Use applicationName() instead of applicationPid() only for sandboxed
applications
This still doesn't make the service name unique, but at least there won't be
collision between
instances running outside the sandbox
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.
are we sure applicationname is unique? what about of multiple instances of
the same application?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D5783
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
are we sure applicationname is unique? what about of multiple instances of
the same application?
REPOSITORY
R289 KNotifications
BRANCH
application-dbus (branched from master)
REVISION DET
jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This is required when using SNI in sandbox (e.g. in flatpak) where the pid
starts from 1,
usually it is 2 (the first one is bwrap) and th
jgrulich added a reviewer: apol.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D5783
To: jgrulich, apol
Cc: #frameworks
