This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5f6bd28119c6: Fix directory based search. (authored by
xuetianweng).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5631?vs=13905&id=17950
REVISION DETAIL
https://
elvisangelaccio added a comment.
Any reason why this hasn't been committed yet?
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5631
To: xuetianweng, #frameworks, lbeltrame
Cc: elvisangelaccio, lbeltrame
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Looks fairly harmless to me. Perhaps wait one or two days more to see if
anyone chimes in.
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D563
xuetianweng added a comment.
I saw there's filesearchstoretest.cpp in autotests/integration, but
CMakeLists.txt doesn't build it. I guess this test might not work yet.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D5631
To: xuetianweng, #frameworks
Cc: lbeltrame
lbeltrame added a comment.
+1, I assume there are no tests for this functionality already present?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D5631
To: xuetianweng, #frameworks
Cc: lbeltrame
xuetianweng created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
canonicalPath() does not include the file name, but only the directory
name. Should use canonicalFilePath() instead.
TEST PLAN
Manually test with baloosearch
REPOSITORY
R293 Baloo
BRA
