This revision was automatically updated to reflect the committed changes.
Closed by commit R240:3d1d436da60a: Fix compilation under AppleClang (authored
by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5379?vs=13284&id=13289
REVISION DETA
kfunk added a comment.
In https://phabricator.kde.org/D5379#100960, @rjvbb wrote:
> LGTM.
>
> Is this related to the compiler features issue in one of Qt's cmake modules?
No, it's related to CMake starting to treat AppleClang & Clang differently
since 3.0
REPOSITORY
R240 Ex
rjvbb accepted this revision.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5379
To: kfunk, apol, rjvbb
Cc: #frameworks, #build_system
rjvbb added a comment.
LGTM.
Is this related to the compiler features issue in one of Qt's cmake modules?
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5379
To: kfunk, apol, rjvbb
Cc: #frameworks, #build_system
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5379
To: kfunk, rjvbb, apol
Cc: #frameworks, #build_system
kfunk added a reviewer: rjvbb.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5379
To: kfunk, rjvbb
Cc: #frameworks, #build_system
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Broken since we started to treat Clang and AppleClang differently (with
the switch to CMake 3.0)
FIXED-IN: v5.
