D5338: Add syntax highlighting file for Doxyfile

2017-07-24 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:916efa110fff: Doxygen: Add Doxyfile highlighting (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5338?vs=13205&id=17112#toc REPOSITORY R216 Syntax Highlighting CHANGE

D5338: Add syntax highlighting file for Doxyfile

2017-07-24 Thread Ernst Maurer
emaurer added a comment. In https://phabricator.kde.org/D5338#128106, @dhaumann wrote: > @emaurer We just agreed that your version is better and would like to use this. Are you also OK with using the MIT license? Currently, we are trying to unify the licensing to MIT for as many of our x

D5338: Add syntax highlighting file for Doxyfile

2017-07-24 Thread Kevin Funk
kfunk abandoned this revision. kfunk added a comment. Note: Abandoning this Diff in favor of the one from @emaurer REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, dhaumann, kwrite-devel, vkrause Cc: turbov, emaurer, #frameworks

D5338: Add syntax highlighting file for Doxyfile

2017-07-24 Thread Dominik Haumann
dhaumann added a comment. @emaurer We just agreed that your version is better and would like to use this. Are you also OK with using the MIT license? Currently, we are trying to unify the licensing to MIT for as many of our xml highlighting files as possible. REPOSITORY R216 Syntax Highli

D5338: Add syntax highlighting file for Doxyfile

2017-06-17 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Any news on this? Also, do we have a unit test on this? Please decide on one version and make a review request again to get this done. REPOSITORY R216 Syntax Highlighting R

D5338: Add syntax highlighting file for Doxyfile

2017-04-12 Thread Alex Turbov
turbov added a comment. my 2 cents: I've used the syntax made by Ernst quite a long time and pretty happy w/ it :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, kwrite-devel, dhaumann Cc: turbov, emaurer, #

D5338: Add syntax highlighting file for Doxyfile

2017-04-12 Thread Ernst Maurer
emaurer added a comment. > Heya, > > indeed, I saw that you had a set of valid keywords. If you're okay with it I'll just pull them in myself & then push this patch. We can work together on adding more stuff to it later on, no problem. sure, feel free to use from mine for a pushing

D5338: Add syntax highlighting file for Doxyfile

2017-04-12 Thread Kevin Funk
kfunk added a comment. In https://phabricator.kde.org/D5338#101466, @emaurer wrote: > In https://phabricator.kde.org/D5338#100575, @kfunk wrote: > > > In https://phabricator.kde.org/D5338#100509, @dhaumann wrote: > > > > > Oh, and see this: https://github.com/KDE/syntax-highlightin

D5338: Add syntax highlighting file for Doxyfile

2017-04-12 Thread Ernst Maurer
emaurer added a comment. In https://phabricator.kde.org/D5338#100575, @kfunk wrote: > In https://phabricator.kde.org/D5338#100509, @dhaumann wrote: > > > Oh, and see this: https://github.com/KDE/syntax-highlighting/pull/5 > > > What the... Created at almost the exact same time? :

D5338: Add syntax highlighting file for Doxyfile

2017-04-08 Thread Kevin Funk
kfunk added a comment. In https://phabricator.kde.org/D5338#100509, @dhaumann wrote: > Oh, and see this: https://github.com/KDE/syntax-highlighting/pull/5 What the... Created at almost the exact same time? :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D5338: Add syntax highlighting file for Doxyfile

2017-04-08 Thread Dominik Haumann
dhaumann added a comment. Oh, and see this: https://github.com/KDE/syntax-highlighting/pull/5 REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, kwrite-devel, dhaumann Cc: #frameworks

D5338: Add syntax highlighting file for Doxyfile

2017-04-08 Thread Dominik Haumann
dhaumann added a comment. I would prevent MIT license for the highlighting - and also for the test. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, kwrite-devel, dhaumann Cc: #frameworks

D5338: Add syntax highlighting file for Doxyfile

2017-04-07 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Thank you, was missing this as well :) Just one nitpick: please make the license attribute more precise, e.g. "LGPLv2+". And if you happen to have a file around you can share, please add

D5338: Add syntax highlighting file for Doxyfile

2017-04-07 Thread Kevin Funk
kfunk edited the summary of this revision. kfunk added reviewers: vkrause, dhaumann, kwrite-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, dhaumann, kwrite-devel Cc: #frameworks

D5338: Add syntax highlighting file for Doxyfile

2017-04-07 Thread Kevin Funk
kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 AFFECTED FILES data/syntax/doxyfile.xml To: kfunk