D5296: Use non-deprecated root element

2017-04-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. Eek, I just learned that changing the doctype name to "kpartgui" breaks the XML standard, which requires this: "The Name in the document type declaration MUST match the element type of the root element." (cmp. https://www.w3.org/TR/xml11/#dt-doctype) That info

D5296: Use non-deprecated root element

2017-04-10 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R263:8629cc027e9f: Use non-deprecated root element (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5296?vs=13081&id=13313 REVISION DETAIL http

D5296: Use non-deprecated root element

2017-04-10 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH usenondeprecatedelement REVISION DETAIL https://phabricator.kde.org/D5296 To: kossebau, #frameworks, aacid Cc: aacid

D5296: Use non-deprecated root element

2017-04-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. Ping? If no-one has further comments or objects, will push around April 17th. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5296 To: kossebau, #frameworks Cc: aacid

D5296: Use non-deprecated root element

2017-04-05 Thread Friedrich W. H. Kossebau
kossebau added a comment. In https://phabricator.kde.org/D5296#99818, @aacid wrote: > Do you know where we do the parsing that allows both gui and kpartgui to be "valid"? > > I did some searching and i think i found it but would be nice if you can find it and we agree on it D:

D5296: Use non-deprecated root element

2017-04-04 Thread Albert Astals Cid
aacid added a comment. Do you know where we do the parsing that allows both gui and kpartgui to be "valid"? I did some searching and i think i found it but would be nice if you can find it and we agree on it D: REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D52

D5296: Use non-deprecated root element

2017-04-03 Thread Friedrich W. H. Kossebau
kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The DTD talks about being deprecated as toplevel element, so the data and tests should follow that. Also fixes wrong DOCTYPE name usage, "gui" instead of "kpartgui" makes no sense given