D5290: FindPyModGen: Don't hard-code share dir

2017-04-04 Thread Aleix Pol Gonzalez
apol added a comment. How is this problem addressed elsewhere? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5290 To: heikobecker, #frameworks, #build_system Cc: apol

D5290: FindPyModGen: Don't hard-code share dir

2017-04-04 Thread Heiko Becker
heikobecker added a comment. In https://phabricator.kde.org/D5290#99713, @apol wrote: > That's not how ECM is intended to work, these find modules are supposed to be separate from the variables we use in KDE. > What problem are you trying to address? My distro uses a di

D5290: FindPyModGen: Don't hard-code share dir

2017-04-04 Thread Aleix Pol Gonzalez
apol added a comment. That's not how ECM is intended to work, these find modules are supposed to be separate from the variables we use in KDE. What problem are you trying to address? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5290 To: heikobeck

D5290: FindPyModGen: Don't hard-code share dir

2017-04-03 Thread Heiko Becker
heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY ...but use KDE_INSTALL_DATAROOTDIR instead. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5290 AFFECTED FILES find-mod