ngraham added a comment.
FWIW, this change did not fix https://bugs.kde.org/show_bug.cgi?id=252483
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5199
To: broulik, hein, dfaure
Cc: ngraham, markg, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ca6e6c0469a5: Reflect trash state in iconNameForUrl
(authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5199?vs=12872&id=24212
REVISION DETAIL
http
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Yep it means parsing a file, but that file is exactly 2 lines long and this
is only done when asking about trash:/ so I think it's fine.
REPOSITORY
R241 KIO
REVISION DETAIL
https://pha
markg added a comment.
Hmm, i don't know about the performance penalty you get when using KConfig...
It "looks" ok, but that's without knowing the above.
+1, ship it is for someone else.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5199
To: broulik, hein, dfaur
bshah resigned from this revision.
This revision now requires review to proceed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5199
To: broulik, hein, dfaure
Cc: #frameworks
bshah added a comment.
Err.. sorry.. accepted wrong revision. Looks good but ignore me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5199
To: broulik, hein, dfaure, bshah
Cc: #frameworks
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5199
To: broulik, hein, dfaure, bshah
Cc: #frameworks
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When doing iconNameForUrl("trash:/") reflect the state of the trash (full or
empty)
TEST PLAN
Did KIO::iconNameForUrl("trash:/") with emp
