This revision was automatically updated to reflect the committed changes.
Closed by commit R572:474c8704ce76: Introduce fetchpo.rb (authored by apol).
REPOSITORY
R572 releaseme
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5133?vs=12696&id=12699
REVISION DETAIL
https://phabricator
sitter accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R572 releaseme
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5133
To: apol, #frameworks, sitter
apol added a dependent revision: D5136: Introduce fetch-translations build
command.
REPOSITORY
R572 releaseme
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5133
To: apol, #frameworks, sitter
apol updated this revision to Diff 12696.
apol added a comment.
Address issue, use git.kde.org repo name as identifier
REPOSITORY
R572 releaseme
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5133?vs=12695&id=12696
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5
sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> l10n.rb:217
>
> -def get(srcdir)
> - # FIXME: this is later used as destination for the weirdest of
> reasons...
> - target = "#{srcdir}/po/"
apol updated this revision to Diff 12695.
apol added a comment.
Address sitter concerns
REPOSITORY
R572 releaseme
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5133?vs=12693&id=12695
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5133
AFFECTED FILES
fetchpo.r
sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.
I really think this should have a simple test case. In particular, the
allow_edit behavior should be asserted somewhere. Also some style nitpicks.
INLINE COMMENTS
> fetchpo.rb:52
apol created this revision.
REVISION SUMMARY
Adds an executable that will allow to retrieve translations for a checked out
project.
TEST PLAN
tests still pass
REPOSITORY
R572 releaseme
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5133
AFFECTED FILES
fetchpo.rb
li
