This revision was automatically updated to reflect the committed changes.
Closed by commit R295:70c2485b2684: [KCModuleProxy] Remove dead code (authored
by broulik).
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5056?vs=12490&id=12948
REVISION DETAIL
http
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I don't know anything about this code, but if it's dead, it's dead.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D5056
To: broulik, dfaure
Cc: ltoscano, #framew
broulik added a comment.
Ping
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D5056
To: broulik, dfaure
Cc: ltoscano, #frameworks
ltoscano added a comment.
There is "Frameworks", which is added as subscriber (not reviewer), but
that's enough to have the email landing on kde-frameworks-devel (which is how I
saw this review).
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D5056
To: broulik, df
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
We don't want GUI stuff run as root, we have PolicyKit, there's no "rootInfo"
anywhere anymore.
More importantly, this empty if condition
