D5003: Update docs to Frameworks API

2017-03-16 Thread Jonathan Riddell
This revision was automatically updated to reflect the committed changes. Closed by commit R283:91b73de5bfbc: Update docs to Frameworks API (authored by jriddell). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5003?vs=12366&id=12544#toc REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D5003: Update docs to Frameworks API

2017-03-13 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That looks about right to me! :) REPOSITORY R283 KAuth BRANCH docs REVISION DETAIL https://phabricator.kde.org/D5003 To: jriddell, leinir Cc: #frameworks

D5003: Update docs to Frameworks API

2017-03-10 Thread Jonathan Riddell
jriddell marked an inline comment as done. jriddell added a comment. added some info to kauthexecutejob.h about AuthStatus data() does get the data returned by the action (not direct return I guess) as well as set during the action, updated. INLINE COMMENTS > leinir wrote in kauthexecut

D5003: Update docs to Frameworks API

2017-03-10 Thread Jonathan Riddell
jriddell updated this revision to Diff 12366. jriddell added a comment. - mention statusChanged REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5003?vs=12365&id=12366 BRANCH docs REVISION DETAIL https://phabricator.kde.org/D5003 AFFECTED FILES src/kau

D5003: Update docs to Frameworks API

2017-03-10 Thread Jonathan Riddell
jriddell updated this revision to Diff 12365. jriddell marked an inline comment as done. jriddell added a comment. - better description for kauthexecutejob data REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5003?vs=12359&id=12365 BRANCH docs REVISION DET

D5003: Update docs to Frameworks API

2017-03-10 Thread Dan Leinir Turthra Jensen
leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Thinking this is... well under way, with a couple of details :) INLINE COMMENTS > kauthactionreply.h:338 > -* > -* In case of errors coming from the library, the type() is > -* Ac

D5003: Update docs to Frameworks API

2017-03-10 Thread Jonathan Riddell
jriddell created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Update API docs TEST PLAN Read them REPOSITORY R283 KAuth BRANCH docs REVISION DETAIL https://phabricator.kde.org/D5003 AFFECTE