This revision was automatically updated to reflect the committed changes.
Closed by commit R238:620b0206ac89: Export a proper shared library for
KDocTools (authored by ltoscano).
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4849?vs=12097&id=12132
REVISION
dfaure added a comment.
I think you can remove the static lib, yes. It didn't "look" like a proper
KF5 lib, being the only static one, and the functions being undocumented, etc.
REPOSITORY
R238 KDocTools
BRANCH
sharedlib
REVISION DETAIL
https://phabricator.kde.org/D4849
To: ltoscano,
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> ltoscano wrote in docbookxslt_p.h:1
> This is not exported, can I fix it later with the other files?
Sure.
REPOSITORY
R238 KDocTools
BRANCH
sharedlib
REVISION DE
ltoscano marked 3 inline comments as done.ltoscano added inline comments.
View RevisionINLINE COMMENTSView Inlinedfaure wrote in docbookxslt_p.h:1
missing copyright header
This is not exported, can I fix it later with the other files?REPOSITORYR238 KDocToolsREVISION DETAILhttps://phabricator.kde.or
ltoscano added a comment.
View RevisionEyes bleeding after digging into the history back to the cvs2svn conversion. At least I will be able to finally update the copyright of the other files (even if apparently originally kdoctools was BSD-like, need to investigate more).
Anyway, if this is accepte
ltoscano updated this revision to Diff 12097.ltoscano added a comment.
View RevisionAdd descriptions and copyrights
Copyrights from the people who touched the signature from this
file and its ancestors.REPOSITORYR238 KDocToolsCHANGES SINCE LAST UPDATEhttps://phabricator.kde.org/D4849?vs=11982&id=1
ltoscano added inline comments.
View RevisionINLINE COMMENTSView Inlinedfaure wrote in docbookxslt.h:1
copyright header missing
For this and all the other notes about missing copyright: I did not write the original code, just reshuffled it in this header (ok, apart one function), so I guess I shoul
dfaure added inline comments.
View RevisionINLINE COMMENTSView Inlineltoscano wrote in docbookxslt.h:1
For this and all the other notes about missing copyright: I did not write the original code, just reshuffled it in this header (ok, apart one function), so I guess I should find the copyright of p
dfaure added inline comments.
View RevisionINLINE COMMENTSView Inlinedocbookxslt.h:1
#ifndef _KDOCTOOLS_XSLT_H_
#define _KDOCTOOLS_XSLT_H_
copyright header missingView Inlinedocbookxslt.h:13
KDOCTOOLS_EXPORT QString transform(const QString &file, const QString &stylesheet,
ltoscano added a reviewer: dfaure.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4849
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano, dfaure
Cc: #frameworks, #documentation
ltoscano added a dependent revision: D4850: Use the new shared library exported
by KDocTools.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4849
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano
Cc: #frameworks, #document
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
This is a unique situation, as the static library was supposed to be
temporary, and the only users are kio_hel
12 matches
Mail list logo
