D4508: Plasma controls based on QtQuickControls2

This revision was automatically updated to reflect the committed changes. Closed by commit R242:76af5399dd95: Plasma controls based on QtQuickControls2 (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11960&id=12454

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

mart added a comment. I would push it right after this frameworks release, ok? REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4508 REVISION DETAIL https://phabricator.kde.org/D4508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart,

[Differential] [Accepted] D4508: Plasma controls based on QtQuickControls2

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4508 REVISION DETAIL https://phabricator.kde.org/D4508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in Label.qml:27 > It probably made sense when it was written, but your comments about layouts > is outdated. > > No manual changes are needed. > > try: > https://paste.kde.org/pgi2ui6e3 > > If it was a problem we'd be seeing i

[Differential] [Updated, 2,977 lines] D4508: Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11960. mart added a comment. - remove custom height REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11948&id=11960 BRANCH arcpatch-D4508 REVISION DETAIL https://phabricator.kde.org/D4508 AF

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in Label.qml:27 > the reason for the padding is that it makes it correctly vertically aligned > with other widgets both in a Row and a RowLayout. > without this default height, every label should be manually vertically > centere

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:42 > It's easier to add something later than to remove it. > > I'd go with not installing for now, then revisit it. Maybe same for Menus. ok. what about the combobox? > davidedmundson wrote in Button.qml:28 >

[Differential] [Updated, 2,978 lines] D4508: Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11948. mart marked 2 inline comments as done. mart added a comment. - don't install files that shouldn't REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11630&id=11948 BRANCH arcpatch-D4508 RE

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

davidedmundson added a comment. Generally good to go. Just one major gripe about Label, and making sure our installed items and qmldir are in sync. INLINE COMMENTS > CMakeLists.txt:11 > + > +#install the componenbts as a QQC2 Style, as style for applications (mainly > for Plasma Mobile) > +

[Differential] [Updated, 2,989 lines] D4508: Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11630. mart marked 2 inline comments as done. mart added a comment. updated with https://phabricator.kde.org/D4522 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11082&id=11630 BRANCH mart/qqc

[Differential] [Updated] D4508: Plasma controls based on QtQuickControls2

mart retitled this revision from "[WIP] Plasma controls based on QtQuickControls2" to "Plasma controls based on QtQuickControls2". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai