cullmann added a comment.
Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel;
removed: Frameworks, Build System.
Is this still relevant? If yes, from the diff, looks ok for me.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4363
To:
vonreth updated this revision to Diff 10822.
vonreth added a comment.
Small fix
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4363?vs=10756&id=10822
BRANCH
arcpatch-D4363
REVISION DETAIL
https://phabricator.kde.org/D4363
AFFECTED FILES
dfaure added a comment.
I'm no expert but this seems ok, no objection from me.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4363
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: vonreth, #windows, bcooksley, alexmer
vonreth added reviewers: Windows, bcooksley, alexmerry, dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4363
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: vonreth, #windows, bcooksley, alexmerry, dfaure
Cc: #fra
vonreth created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Setting the gnu style compiler flags with clang-cl results in a
huge bunch of unknown argument warnings.
The
