D3850: Pass -fno-operator-names when supported

kfunk closed this revision. kfunk added a comment. Closing. Please just strip the flag from CMake flags if you're using a library making use of alternative tokens. We've just seen compilation failing early because some lib in KF5 accidentally used alternative tokens => would have broken

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

nalvarez added a comment. This might be better solved by a krazy-like check, instead of making the compilation fail... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. I start to agree that it's probably better to revert this patch, for the simple reason: We might break compilation of a project using boost if boost decides to add code which uses alternative tokens to any of its headers. This is not under our control. On the othe

[Differential] [Reopened] D3850: Pass -fno-operator-names when supported

thomasp reopened this revision. thomasp added a comment. This revision is now accepted and ready to land. Alternative tokens [lex.digraph] are standard c++ and have been since it's was standardized (and I don't know of any plan to deprecate them). They are a accessibility feature, since not e

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

elvisangelaccio added a comment. In https://phabricator.kde.org/D3850#72081, @kfunk wrote: > In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > > > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like a

[Differential] [Closed] D3850: Pass -fno-operator-names when supported

This revision was automatically updated to reflect the committed changes. Closed by commit R240:a5f3a76e1479: Pass -fno-operator-names when supported (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3850?vs=9443&id=10205 REVISIO

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: I'll push this after the imminent KF5 release if no-one objects. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfun

[Differential] [Accepted] D3850: Pass -fno-operator-names when supported

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Fine by me. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72308, @rakuco wrote: > Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? -fno-operator-names is an ancient compiler flag, supported by GCC since at least 2000

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

rakuco added a comment. Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

ltoscano added a reviewer: Buildsystem. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ivan, #buildsystem Cc: elvisangelaccio

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like and use them whenever I start something from scratch... Hmm... You cou

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

elvisangelaccio added a comment. What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like and use them whenever I start something from scratch... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

kfunk added a reviewer: ivan. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ivan

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: Just refreshing my complete KF5 build to test the change. kactivities fails: /home/kfunk/devel/src/kf5/kactivities/autotests/common/test.h:143:25: error: token is not a valid binary operator in a preprocessor subexpression #if defined(Q_NO_DEBUG) or

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

kfunk added a reviewer: Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks