This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1b9b239eb262: [OpenUrlJob] Improve comments/docs
(authored by ahmadsamir).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29528?vs=82286&id=82304
REVISION DETAIL
htt
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
l-late (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29528
To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, b
ahmadsamir updated this revision to Diff 82286.
ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.
Address comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29528?vs=82260&id=82286
BRANCH
l-late (branched from master)
REVISION DE
ahmadsamir marked 2 inline comments as done.
ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in openurljob.cpp:590
> That one was on purpose. I find this version less readable, mixing a test and
> an actual action (with error handling).
Fair point.
REPOSITORY
R241 KIO
REVIS
dfaure added a comment.
Thanks!
INLINE COMMENTS
> openurljob.cpp:393
> +if (mime.isValid() && mimeName != m_mimeTypeName) {
> +m_mimeTypeName =mimeName;
> }
missing space after '='
> openurljob.cpp:590
> +const QMimeType mimeType = db.mimeTypeForName(m_mimeT
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REPOSITORY
R241 KIO
BRANCH
l-late (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29528
AFFECTED FILES
