D29455: KNS: Remove isRemote method and handle parse error properly

2020-05-05 Thread Dan Leinir Turthra Jensen
leinir requested changes to this revision. leinir added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > installation.h:76 > bool readConfig(const KConfigGroup &group); > -bool isRemote() const; > i'm afraid this is an exported class, at most we can ma

D29455: KNS: Remove isRemote method and handle parse error properly

2020-05-05 Thread Alexander Lohnau
alex created this revision. alex added reviewers: KNewStuff, ngraham, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The isRemote check and the FIXMEs are removed, instead the result from the