This revision was automatically updated to reflect the committed changes.
Closed by commit R244:3d30318e4d37: API dox: document Q_DECLARE_FLAGS-based
flags (authored by kossebau).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28986?vs=80569&id=80571
REVI
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
documentFlags
REVISION DETAIL
https://phabricator.kde.org/D28986
To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
dfaure added a comment.
Sure.
REPOSITORY
R244 KCoreAddons
BRANCH
documentFlags
REVISION DETAIL
https://phabricator.kde.org/D28986
To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
kossebau added a comment.
If okay, I would walk over the other KF modules and apply the same pattern
there as well, once this here is accepted.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D28986
To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGa
kossebau updated this revision to Diff 80569.
kossebau added a comment.
drop the "OR" from "OR combination"
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28986?vs=80562&id=80569
BRANCH
documentFlags
REVISION DETAIL
https://phabricator.kde.org/D28
kossebau added inline comments.
INLINE COMMENTS
> dfaure wrote in kjob.h:99
> Inexperienced developers might be confused by the OR in there.
> In English it sounds like exclusive or, while the whole point of
> Q_DECLARE_FLAGS is that multiple flags can be set at the same time.
>
> Why not just
dfaure added inline comments.
INLINE COMMENTS
> kjob.h:99
> +/**
> + * Stores an OR combination of #Capability values.
> + */
Inexperienced developers might be confused by the OR in there.
In English it sounds like exclusive or, while the whole point of
Q_DECLARE_FLAGS is that multi
kossebau created this revision.
kossebau added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
KApiDox & ECMAddQch have been just teached about Q_DECLARE_FLAGS, so the
