D28800: Always create actioncollection

kossebau added inline comments. INLINE COMMENTS > kbookmarkmenu.cpp:69 > { > m_actionCollection = actionCollection; > } This resetting of m_actionCollection in the constructor taking an actionCollection still results in issues, as this KBookmarkMenu constructor taking an actionCollecti

D28800: Always create actioncollection

This revision was automatically updated to reflect the committed changes. Closed by commit R294:4b3fc2aedd86: Always create actioncollection (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28800?vs=80034&id=80051 REVISION DETAIL

D28800: Always create actioncollection

nicolasfella added a comment. In D28800#647508 , @dfaure wrote: > (but now konqueror creates another one, so the konqueror patch needs to changed to "if exactly 5.69" only, right?) makes sense REPOSITORY R294 KBookmarks BRANCH empty

D28800: Always create actioncollection

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. (but now konqueror creates another one, so the konqueror patch needs to changed to "if exactly 5.69" only, right?) REPOSITORY R294 KBookmarks BRANCH emptycoll REVISION DE

D28800: Always create actioncollection

nicolasfella added reviewers: Frameworks, dfaure, stefanocrocco. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D28800 To: nicolasfella, #frameworks, dfaure, stefanocrocco Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Otherwise subclasses that unconditionally use m_actionCollection will get crashes. Observed in D28789