D28532: Introduce more user-visible error reporting for installations

This revision was automatically updated to reflect the committed changes. Closed by commit R304:eb23f549ea9b: Introduce more user-visible error reporting for installations (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28532?vs=79474&id

D28532: Introduce more user-visible error reporting for installations

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH more-installation-error-handling (branched from master) REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-framew

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

leinir updated this revision to Diff 79474. leinir added a comment. - Merge branch 'master' into more-installation-error-handling - Actually read the error (not just all) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28532?vs=79195&id=79474 BRANCH m

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

leinir updated this revision to Diff 79195. leinir added a comment. - Address @pino's comment re i18n overload usage REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28532?vs=79191&id=79195 BRANCH more-installation-error-handling (branched from master)

D28532: Introduce more user-visible error reporting for installations

pino added a comment. Please fix the i18n() calls, as the values of placeholders are passed as parameter to it instead of using .arg(): i18n("foo %1").arg(foo) // WRONG i18n("foo %1", foo) // correct REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D2853

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

leinir edited the summary of this revision. leinir added reviewers: KNewStuff, Plasma, ngraham, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, mi

D28532: Introduce more user-visible error reporting for installations

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this, we did have error reporting, but only in the way of writing errors out on the command line (through qCCri