hchain updated this revision to Diff 78863.
hchain added a comment.
remove binary
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28421?vs=78848&id=78863
REVISION DETAIL
https://phabricator.kde.org/D28421
AFFECTED FILES
src/services/kautostart.cpp
s
davidedmundson added inline comments.
INLINE COMMENTS
> hchain wrote in kde-systemd-start-condition.cpp:20
> so I could silently join the arguments with spaces ?
As long as
kde-systemd-start-condition "foo bar:foo bar:foo:true"
does work properly, we can leave this as-is and just make sure the
hchain added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kde-systemd-start-condition.cpp:17
> Should it be showHelp(255)?
>
> Not that we should end up here in the generated case.
I intentionally return 0 here to mimic the behavior of KAutostart which returns
true if the condit
davidedmundson added a comment.
Code is fine; both the change in KAutostart and the helper.
I'm not sure if this the helper should be in the framework.
X-KDE-Autostart condition is very tied to Plasma doing the booting, at which
point we're better off putting the binary in plasma-wor
hchain created this revision.
hchain added reviewers: davidedmundson, broulik, dfaure, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hchain requested review of this revision.
REVISION SUMMARY
For systemd autostart generator will add a
ExecConditi
