dfaure added a comment.
Thanks for the detailed review!
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28187
To: dfaure, ahmadsamir, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
dfaure closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28187
To: dfaure, ahmadsamir, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
ahmadsamir accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28187
To: dfaure, ahmadsamir, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
ahmadsamir added a comment.
Neat.
The logic all seems to hold:
We have no urls:
- if it's a local file, useKioexec is false, and no fuse since "requests"
will be empty
- if it's not a local file, useKioexec is true, and we try fuse; if there's
an error with fuse fallback to k
dfaure created this revision.
dfaure added reviewers: ahmadsamir, feverfew, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
- Remove special case for hasSchemeHandler, it's just a hack.
