D28163: Add input-dialpad and call-voicemail

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:214dcc72f020: Add input-dialpad and call-voicemail (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE

D28163: Add input-dialpad and call-voicemail

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

ndavis updated this revision to Diff 78136. ndavis added a comment. - Use evenly distributed and proportioned style for dialpad REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28163?vs=78107&id=78136 BRANCH dialpad-voicemail (branched from master) R

D28163: Add input-dialpad and call-voicemail

ngraham added a comment. Well, I'm out of ideas REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

ndavis added a comment. In D28163#631474 , @ngraham wrote: > Maybe we could keep the dots 2x2 for the 22px version? You can't get even spacing unless you make it way smaller than a normal 22px icon. REPOSITORY R266 Breeze Icons REVISI

D28163: Add input-dialpad and call-voicemail

bshah added a comment. Hmm yeah I am also not a fan of the stretched out dialpad icon REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

ngraham added a comment. Maybe we could keep the dots 2x2 for the 22px version? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

ndavis added a comment. In D28163#631346 , @ngraham wrote: > I thought the margins were maximums. Making the icon skinnier seems fine to me. they are maximums. those guides are at the canvas size. At the correct proportion, it's 22px tal

D28163: Add input-dialpad and call-voicemail

ngraham added a comment. I thought the margins were maximums. Making the icon skinnier seems fine to me. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

ndavis added a comment. In D28163#631343 , @ngraham wrote: > The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. The others look fine. I agree, but it's really hard to get the proportions right and have it respect

D28163: Add input-dialpad and call-voicemail

ngraham added a comment. The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. The others look fine. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, m

D28163: Add input-dialpad and call-voicemail

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28163: Add input-dialpad and call-voicemail

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Requested by @bshah for Plasma Mobile REPOSITORY R266 Breeze Icons BRANCH dialpad-voic