D28130: Introduce api for passive notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R296:cebaeb4daf59: Introduce api for passive notifications (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28130?vs=77983&id=77987 REVISION DETA

D28130: Introduce api for passive notifications

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH phab/passivenot REVISION DETAIL https://phabricator.kde.org/D28130 To: mart, broulik Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28130: Introduce api for passive notifications

mart updated this revision to Diff 77983. mart added a comment. - const QVariant & REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28130?vs=77982&id=77983 BRANCH phab/passivenot REVISION DETAIL https://phabricator.kde.org/D28130 AFFECTED FILES

D28130: Introduce api for passive notifications

mart updated this revision to Diff 77982. mart added a comment. - const QVariant & REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28130?vs=77940&id=77982 BRANCH phab/passivenot REVISION DETAIL https://phabricator.kde.org/D28130 AFFECTED FILES

D28130: Introduce api for passive notifications

mart added a comment. In D28130#630325 , @davidre wrote: > I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions? doesn't really *need* it, but matches the existing api already existing in

D28130: Introduce api for passive notifications

mart added a comment. In D28130#630325 , @davidre wrote: > I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions? doesn't really *need* it, but matches the existing api already existing in

D28130: Introduce api for passive notifications

davidre added a comment. I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28130 To: mart Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28130: Introduce api for passive notifications

broulik added inline comments. INLINE COMMENTS > configmodule.h:507 > + */ > +void showPassiveNotification(const QString &message, QVariant timeout = > QVariant(), const QString &actionText = QString(), const QJSValue &callBack = > QJSValue()); > Q_SIGNALS: `const QVariant &` REPOSIT

D28130: Introduce api for passive notifications

mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28130 To: mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY showPassiveNotification which mirrors ApplicationWindow.showPassiveNotification some kcms need to show a tiny non interrup