apol updated this revision to Diff 77467.
apol added a comment.
Fix as suggested
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27953?vs=77305&id=77467
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27953
AFFECTED FILES
src/services/ks
dfaure added a comment.
How? You think we should change all our config files to use ';'? Welcome to
migration hell.
(I looked at the KConfig history, and in fact the separator was initially a
method argument which defaulted to comma, I was wrong about it being ';'
initially. No idea how
broulik added a comment.
Do we have a task to clean that mix up for kf6 on the work board?
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D27953
To: apol, dfaure
Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
This sounds wrong. The XDG-mandated entries use XDG separators, but the KDE
entries don't (for instance, grepping my installed desktop files I can see
those: X-Plasma-RequiredExte
apol added a dependent revision: D27954: appstreamrunner: Port to
KApplicationTrader.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D27953
To: apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
apol created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
If we know that a field is a StringList, read it with the XDG string list
specific codepath.
Otherwise we get something suc
