D27597: KRunner: Refactor deprecated toSet() method

alex abandoned this revision. alex added a comment. This gets already handled/discussed in D28135 REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D27597 To: alex, mlaurent, apol, #plasma Cc: ahmadsamir, kde-frameworks-devel, LeGas

D27597: KRunner: Refactor deprecated toSet() method

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense. It would be ideal to have a way to do an unsorted comparison without having to create 2 temporary sets every time, although I guess it's out of scope here. REPOSITORY R308 KRunn

D27597: KRunner: Refactor deprecated toSet() method

alex added a reviewer: Plasma. alex added a comment. Thanks :-) REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D27597 To: alex, mlaurent, apol, #plasma Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27597: KRunner: Refactor deprecated toSet() method

alex updated this revision to Diff 76219. alex added a comment. Keep compatibility with Qt < 5.14 REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27597?vs=76213&id=76219 BRANCH deprecation_fix (branched from master) REVISION DETAIL https://phabricator.

D27597: KRunner: Refactor deprecated toSet() method

ahmadsamir added a comment. Hi there. Since KF5 min. supported Qt version is 5.12, you have to make the code conditional so that it still build on Qt < 5.14. (Qt 5.14 is where range-iterators-based constructors were introduced to Qt containers including QList https://doc.qt.io/qt-5/qlist

D27597: KRunner: Refactor deprecated toSet() method

alex created this revision. alex added reviewers: mlaurent, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The deprecated toSet method of the QList class has been refactored as in the deprecatio