D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

ervin added a comment. Yes, we really need a large clean up in this area, we got strata of old cruft layered on top often with duplicated states between them. We also have the widget and QML cases being very different in their state management (one comparing widget content with the settings

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

ervin added a comment. Sounds innocuous indeed and I always found that queued connection weird... I mean resetting to false whatever happens during load? That's fine for simple cases but not real complex ones. Still, can we have some more extensive testing on a good chunk of the modules

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

davidedmundson added a comment. I found out why this was added. 7e4b9688d52f55828ba4a5b82e9d8fe5b1a5ff94 In 2008 things changed to being loaded in the showEvent Many people blindly connecting to widgets chan

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

bport created this revision. bport added reviewers: Plasma, davidedmundson, ervin, crossi, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Currently from David Edmundson comment on https://phabr