This revision was automatically updated to reflect the committed changes.
Closed by commit R237:fb29718d3ac6: Fix some compiler warnings (authored by
ahmadsamir).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27158?vs=80753&id=80754
REVISION DETAIL
https:/
ahmadsamir updated this revision to Diff 80753.
ahmadsamir added a comment.
Rebase
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27158?vs=75028&id=80753
BRANCH
l-compiler-warnings (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
l-compiler-warnings (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27158
To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblac
ahmadsamir updated this revision to Diff 75028.
ahmadsamir added a comment.
Add missing space after ,
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27158?vs=75009&id=75028
BRANCH
l-compiler-warnings (branched from master)
REVISION DETAIL
https://phab
dfaure added inline comments.
INLINE COMMENTS
> KConfigCodeGeneratorBase.cpp:45
> ParseResult &parseResult)
> -: m_inputFile(inputFile), m_baseDir(baseDir), m_fileName(fileName),
> m_cfg(parameters), parseResult(parseResult)
> +: parseResult(parseResult), m_inputFile(inputFile),m_ba
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
- Fix order of member initialisation (compiling with -Wreorder)
- Use Q_UNUSED where needed
- QAtomicInte
