leinir added a reviewer: KNewStuff.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D27028
To: leinir, bcooksley, #frameworks, #knewstuff
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
leinir updated this revision to Diff 75044.
leinir marked an inline comment as done.
leinir added a comment.
During some cleanup and addition, i realised it was silly to have
the documentation for knsrc files in the widgets bits, and in two
places. In addition, those places were both at lea
leinir marked 6 inline comments as done.
leinir added inline comments.
INLINE COMMENTS
> meven wrote in khotnewstuff.knsrc:2
> Better set this to https then, to make it explicit and not relying on server
> expectations.
Quite - that redirection isn't what these test knsrc files are supposed to
leinir updated this revision to Diff 74896.
leinir added a comment.
Address comments by meven and bcooksley
- Make sure we're using https
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27028?vs=74687&id=74896
BRANCH
fix-dko-overload-by-switching-t
meven added inline comments.
INLINE COMMENTS
> bcooksley wrote in khotnewstuff.knsrc:2
> Yes, this should be https - the server will redirect to https (which sets
> HSTS headers) in any case.
Better set this to https then, to make it explicit and not relying on server
expectations.
REPOSITORY
bcooksley added inline comments.
INLINE COMMENTS
> meven wrote in khotnewstuff.knsrc:2
> Shouldn't it be in https ?
Yes, this should be https - the server will redirect to https (which sets HSTS
headers) in any case.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D2
meven added inline comments.
INLINE COMMENTS
> khotnewstuff.knsrc:2
> [KNewStuff3]
> -ProvidersUrl=http://download.kde.org/ocs/providers.xml
> +ProvidersUrl=http://autoconfig.kde.org/ocs/providers.xml
> Categories=KDE Wallpaper 1920x1200,KDE Wallpaper 1600x1200
Shouldn't it be in https ?
REPO
leinir updated this revision to Diff 74687.
leinir added a comment.
Thanks to broulik for noticing (or making me notice) this
- Don't change a thing that deals with legacy data
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27028?vs=74676&id=74687
B
leinir added inline comments.
INLINE COMMENTS
> broulik wrote in cache.cpp:160
> We use `https` everywhere these days
Yup, this wants to be left alone... i'll add a little comment to that effect.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D27028
To: leinir, bcoo
leinir added inline comments.
INLINE COMMENTS
> broulik wrote in cache.cpp:160
> We use `https` everywhere these days
Yes, quite, we certainly do. (i'm also wondering if this is really something
that wants changing or not, as it's... in a bit that loads KNS2 cache files...
from KDE3)
REPOSITO
broulik added inline comments.
INLINE COMMENTS
> cache.cpp:160
> +if
> (e.payload().startsWith(QLatin1String("http://download.kde.org/khotnewstuff";))
> + ||
> e.payload().startsWith(QLatin1String("http://autoconfig.kde.org/khotnewstuff";)))
> {
> // Th
leinir updated this revision to Diff 74676.
leinir added a comment.
As suggested by frinring, do not suggest setting a ProvidersUrl unless
it is actually needed.
- Rework the knsrc description comment, suggest not setting ProvidersUrl
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDA
leinir added reviewers: bcooksley, Frameworks.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D27028
To: leinir, bcooksley, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
Rather than suggest using dko for provider files, we should be
suggesting autoconfig.k.o, which is a more capable servic
14 matches
Mail list logo
