SGOrava added a comment.
No, my tests say no.
This does not update sizeHint which can cause some issue later.
It sure looks nice in my test app but it is wrong in the core.
This is not the right solution.
REPOSITORY
R236 KWidgetsAddons
BRANCH
more-proper-height (branched from master
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
I just tested with KTextEditor's messagetest and KTextEditor's usage of
KMessageWidget in the top and bottom bar, and all this looks still good.
+1 from my side. Another review woul
SGOrava added a comment.
OK, I will try to write a test for it.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGOrava, #frameworks
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dhaumann added a comment.
Since KTextEditor uses KMessageWidget extensively we have to make sure the
unit test messagetest still passes with this change.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGOrava, #frameworks
Cc: dhaumann, kde-framewor
SGOrava edited the summary of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGOrava, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
SGOrava created this revision.
SGOrava added a reviewer: Frameworks.
Herald added a project: Frameworks.
SGOrava requested review of this revision.
REVISION SUMMARY
When the resize event was triggered only the content
was resized and the widget itself was kept with same
height. This results
