This revision was automatically updated to reflect the committed changes.
Closed by commit R240:e8abb9601c7d: ECMAddAppIcon: Add sc in regex to extract
extension from valid names (authored by patrickelectric).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.
patrickelectric added a comment.
@apol I did update the commit body to explain why.
For the text I used https://regex101.com with the icon in the commit body and
printing the variables of CMAKE_MATCH_1 and CMAKE_MATCH_2
Let me know if you agree with this to land the patch, this is necessar
patrickelectric updated this revision to Diff 73927.
patrickelectric added a comment.
Add commit body
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26751?vs=73830&id=73927
BRANCH
sc_appicon
REVISION DETAIL
https://phabricator.kde.org/D267
apol accepted this revision.
apol added a comment.
Looks good to me, bonus points if you provide a better commit message
explaining what it does and how you tested it.
REPOSITORY
R240 Extra CMake Modules
BRANCH
sc_appicon
REVISION DETAIL
https://phabricator.kde.org/D26751
To: patrick
patrickelectric added a reviewer: apol.
REPOSITORY
R240 Extra CMake Modules
BRANCH
sc_appicon
REVISION DETAIL
https://phabricator.kde.org/D26751
To: patrickelectric, tcanabrava, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
michaelh, ngraham, bruns
tcanabrava accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
sc_appicon
REVISION DETAIL
https://phabricator.kde.org/D26751
To: patrickelectric, tcanabrava
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreas
patrickelectric added a comment.
From ECMInstallIcons:
is a numeric pixel size (typically 16, 22, 32, 48, 64, 128 or 256) or
sc for scalable (SVG) files, is one of the standard FreeDesktop.org
icon groups (actions, animations, apps, categories, devices, emblems, emotes,
intl, mimetype
patrickelectric created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
patrickelectric requested review of this revision.
REVISION SUMMARY
Signed-off-by: Patrick José Pereira
REPOSITORY
R240 Extra CMake Modules
