D26560: Fix selection printing

2020-03-09 Thread Robert Hoffmann
hoffmannrobert added a comment. In case my last comment was mistakable, I fixed this: > 1. Create a document with just one long line that wraps over two printed pages. I this case, I am not able to print only the selected text properly. but I couldn't fix this: > 2. Say you have

D26560: Fix selection printing

2020-01-29 Thread Robert Hoffmann
hoffmannrobert added a comment. Here is the fix for 1. I've tried number 2, but I didn't get anywhere. I think this would need huge efforts: To remove the empty space before (and after) the selection you would have to change the layout, which is tied to the document, so basically you wo

D26560: Fix selection printing

2020-01-29 Thread Robert Hoffmann
hoffmannrobert updated this revision to Diff 74577. hoffmannrobert added a comment. - Fix 1: long lines wrapping over pages REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26560?vs=73197&id=74577 BRANCH fix_selection_printing REVISION DETAIL https:/

D26560: Fix selection printing

2020-01-17 Thread Christoph Cullmann
cullmann added a comment. Cool! Thanks for taking care of this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26560 To: hoffmannrobert, dhaumann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demskin

D26560: Fix selection printing

2020-01-17 Thread Robert Hoffmann
hoffmannrobert added a comment. Yes, I am working on it. Now, I have a solution for 1, but 2 is more difficult to fix. Probably next week. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26560 To: hoffmannrobert, dhaumann Cc: kwrite-devel, kde-frameworks-devel, r

D26560: Fix selection printing

2020-01-13 Thread Dominik Haumann
dhaumann added a comment. That looks already better: If a line is wrapped and on the same page, then only the selected text is printed. It seems there are still corner cases. 1. Create a document with just one long line that wraps over two printed pages. I this case, I am not able to pri

D26560: Fix selection printing

2020-01-13 Thread Robert Hoffmann
hoffmannrobert added a reviewer: dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26560 To: hoffmannrobert, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26560: Fix selection printing

2020-01-10 Thread Robert Hoffmann
hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Printing selected text only worked correctly if the lines from which text was selected