D26410: Port KLanguageButton from KConfig to QSettings

2020-01-04 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks, davidedmundson, aacid Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26410: Port KLanguageButton from KConfig to QSettings

2020-01-04 Thread Albert Astals Cid
aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks, davidedmundson, aacid Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26410: Port KLanguageButton from KConfig to QSettings

2020-01-04 Thread Nicolas Fella
nicolasfella added a comment. In D26410#587473 , @pino wrote: > IIRC `KConfigGroup::readEntry() reads the translated version of the key, and every `kf5_entry.desktop` has such translations. QSettings does not do that. > > Did you test only in

D26410: Port KLanguageButton from KConfig to QSettings

2020-01-04 Thread Pino Toscano
pino added a comment. IIRC `KConfigGroup::readEntry() reads the translated version of the key, and every `kf5_entry.desktop` has such translations. QSettings does not do that. Did you test only in an English setup? REPOSITORY R265 KConfigWidgets BRANCH klb REVISION DETAIL https:/

D26410: Port KLanguageButton from KConfig to QSettings

2020-01-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH klb REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26410: Port KLanguageButton from KConfig to QSettings

2020-01-03 Thread Nicolas Fella
nicolasfella added a task: T12197: Move KLanguageButton from KConfig -> QSettings. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26410: Port KLanguageButton from KConfig to QSettings

2020-01-03 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Implement T12197 TEST PLAN