kossebau added a comment.
Pushed a8c3ab79912fcb25d7e59a04c08752a9252a5f08 as hotfix for now.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D26394
To: kfunk, dfaure, winterz, vkrause, apol
Cc: kossebau, lbeltrame, cgiboudeaux, kde-frameworks-devel, kde-bu
kossebau added inline comments.
INLINE COMMENTS
> ECMGeneratePriFile.cmake:183
> + set(PRI_TARGET_MODULE_CONFIG "")
> + get_target_property(target_type ${EGPF_LIB_NAME} TYPE)
> + if (target_type STREQUAL "STATIC_LIBRARY")
Hmpf, this adds the firm assumption that EGPF_LIB_NAME actually is a ta
lbeltrame added subscribers: cgiboudeaux, lbeltrame.
lbeltrame added a comment.
This breaks stuff in PIM:
[ 107s] CMake Error at /usr/share/ECM/modules/ECMGeneratePriFile.cmake:183
(get_target_property):
[ 107s] get_target_property() called with non-existent target
"KF5AlarmCal".
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:fafbc8cec665: ECMGeneratePriFile: Fix static
configurations (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26394?vs=72687&id=75155
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26394
To: kfunk, dfaure, winterz, vkrause, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreas
kfunk added reviewers: winterz, vkrause.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D26394
To: kfunk, dfaure, winterz, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
michaelh, ngraham, bruns
kfunk created this revision.
kfunk added a reviewer: dfaure.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kfunk requested review of this revision.
REVISION SUMMARY
Populate module_config with staticlib. This is needed for Qt 5.
