D26368: Add an isImmutable to know if a property is immutable

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d46739294d04: Add an isImmutable to know if a property is immutable (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=74589

D26368: Add an isImmutable to know if a property is immutable

meven added a reviewer: dfaure. REPOSITORY R237 KConfig BRANCH arcpatch-D26368 REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks, dfaure Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH arcpatch-D26368 REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26368: Add an isImmutable to know if a property is immutable

tcanabrava added a comment. it's a +1 for me. @dfaure and @ervin ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

meven updated this revision to Diff 74589. meven added a comment. Make isImmutable function constant PROPERTY when generateProperties is passed REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=74582&id=74589 BRANCH arcpatch-D26368 REVISION DETAIL

D26368: Add an isImmutable to know if a property is immutable

meven updated this revision to Diff 74582. meven added a comment. Allow the isImmutable to be invokable from Qml when generateProperties is set REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=74563&id=74582 BRANCH arcpatch-D26368 REVISION DETAIL

D26368: Add an isImmutable to know if a property is immutable

meven added a comment. In D26368#602498 , @tcanabrava wrote: > I like it, but considering that this adds a new method, I'd like to see it exposed to Qml too o the generated code if GenerateProperties is set to true, currently we write this kind

D26368: Add an isImmutable to know if a property is immutable

tcanabrava added a comment. I like it, but considering that this adds a new method, I'd like to see it exposed to Qml too o the generated code if GenerateProperties is set to true, currently we write this kind of code in Qml: enabled: !kcm.balooSettings.isImmutable("indexingE

D26368: Add an isImmutable to know if a property is immutable

ervin added subscribers: tcanabrava, dfaure. ervin added a comment. LGTM but lets' wait for a second pair of eyes. Mines are definitely not sharp today. :-) @tcanabrava @dfaure, opinions? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #

D26368: Add an isImmutable to know if a property is immutable

meven updated this revision to Diff 74563. meven added a comment. Clean unnecessary files REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=74561&id=74563 BRANCH arcpatch-D26368 REVISION DETAIL https://phabricator.kde.org/D26368 AFFECTED FILES

D26368: Add an isImmutable to know if a property is immutable

meven updated this revision to Diff 74561. meven added a comment. Rebase & update tests REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26368?vs=72618&id=74561 BRANCH arcpatch-D26368 REVISION DETAIL https://phabricator.kde.org/D26368 AFFECTED FILES

D26368: Add an isImmutable to know if a property is immutable

ervin added a comment. In D26368#602296 , @meven wrote: > In D26368#602254 , @ervin wrote: > > > Now that the refactoring landed, what about rebasing this one? > > > That's almost a complete rew

D26368: Add an isImmutable to know if a property is immutable

meven added a comment. In D26368#602254 , @ervin wrote: > Now that the refactoring landed, what about rebasing this one? That's almost a complete rewrite ^^ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368

D26368: Add an isImmutable to know if a property is immutable

ervin added a comment. Now that the refactoring landed, what about rebasing this one? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

meven edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Add a utility function isImmutable to access immutability quickly. Generated cla