D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

2020-01-26 Thread Waqar Ahmed
waqar added inline comments. INLINE COMMENTS > guesslanguage.cpp:745 > > -while (it.hasNext() && counter < m_maxItems && confidence < > m_minConfidence) { > +while (it.hasNext() && counter < m_maxItems && (m_minConfidence == 0.0 > || confidence < m_minConfidence)) { > it.next

D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

2020-01-01 Thread Michel Ludwig
mludwig updated this revision to Diff 72552. mludwig added a comment. Small fix to the documentation. REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26346?vs=72551&id=72552 REVISION DETAIL https://phabricator.kde.org/D26346 AFFECTED FILES src/core/gues

D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

2020-01-01 Thread Michel Ludwig
mludwig created this revision. mludwig added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mludwig requested review of this revision. REVISION SUMMARY The documentation states that "Default is returning best guess without caring abo