D26321: Expose show-line-count in the ConfigInterface

2020-01-01 Thread Michel Ludwig
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:3026a9caa868: Add "line-count" property to the ConfigInterface (authored by mludwig). CHANGED PRIOR TO COMMIT https:/

D26321: Expose show-line-count in the ConfigInterface

2019-12-31 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. Ok with this... Thanks. A note " Since 5.6x would be nice". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26321 To: mludwig, #ktexteditor, cullmann, dhaumann Cc: dhaumann, cullmann, kwrite-devel, kde-fra

D26321: Expose show-line-count in the ConfigInterface

2019-12-31 Thread Michel Ludwig
mludwig added a comment. In D26321#585381 , @cullmann wrote: > I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document. > Y

D26321: Expose show-line-count in the ConfigInterface

2019-12-31 Thread Michel Ludwig
mludwig updated this revision to Diff 72484. mludwig added a comment. Add "line-count" to KTextEditor::ViewPrivate::configKeys() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26321?vs=72445&id=72484 REVISION DETAIL https://phabricator.kde.org/D26321

D26321: Expose show-line-count in the ConfigInterface

2019-12-31 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document.

D26321: Expose show-line-count in the ConfigInterface

2019-12-31 Thread Michel Ludwig
mludwig created this revision. mludwig added a reviewer: KTextEditor. mludwig added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mludwig requested review of this revision. REVISION SUMMARY The show-line-count prope