D26294: Allow to load widget based KCMs from kcms subdir

2019-12-31 Thread Aleix Pol Gonzalez
apol added a comment. It would be useful if you were a bit more explicit about how you tested it on the commit message. INLINE COMMENTS > kcmoduleloader.cpp:103 > if (!cm) { > +module = factory->create(parent, args2); > +if (module) {

D26294: Allow to load widget based KCMs from kcms subdir

2019-12-30 Thread Alexander Volkov
volkov added a dependent revision: D26244: Install all kcm plugins into kcms subdir. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26294 To: volkov, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

2019-12-30 Thread Alexander Volkov
volkov updated this revision to Diff 72393. volkov added a comment. change branch REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26294?vs=72392&id=72393 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26294 AFFECTED FILES src/kcmodulelo

D26294: Allow to load widget based KCMs from kcms subdir

2019-12-30 Thread Alexander Volkov
volkov added a reviewer: Frameworks. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26294 To: volkov, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26294: Allow to load widget based KCMs from kcms subdir

2019-12-30 Thread Alexander Volkov
volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REPOSITORY R295 KCMUtils BRANCH xxx REVISION DETAIL https://phabricator.kde.org/D26294 AFFECTED FILES src/kcmoduleloader.cpp To: