D26136: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R265:05ea3d2926e7: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72780&id=72781 REVISION D

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72780. ahmadsamir added a comment. Rebase REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72083&id=72780 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde

D26136: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, G

D26136: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26136#582140 , @ahmadsamir wrote: > Verbatim, take 2, with Summary: added manually In D26136#582140 , @ahmadsamir wrote: > Verbatim, take 2, with Summa

D26136: Port QRegExp to QRegularExpression

ahmadsamir edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72083. ahmadsamir added a comment. Verbatim, take 2, with Summary: added manually REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72081&id=72083 BRANCH l-qregularexpression (branched from master) R

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72081. ahmadsamir added a comment. Verbatim REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72035&id=72081 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.k

D26136: Port QRegExp to QRegularExpression

apol added a comment. It didn't update here? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26136: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26136#581721 , @apol wrote: > I'm a bit confused as to why the regex needs to be different. Explain in the commit message? Fair point. Done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phab

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72035. ahmadsamir added a comment. Explain why the regex was changed REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=71923&id=72035 BRANCH l-qregularexpression (branched from master) REVISION DETAI

D26136: Port QRegExp to QRegularExpression

apol added a comment. I'm a bit confused as to why the regex needs to be different. Explain in the commit message? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngr

D26136: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: Frameworks. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R265 KConfigWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://