D26130: Simplify return logic

2020-01-29 Thread Tomaz Canabrava
tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26130 To: tcanabrava, patrickelectric, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26130: Simplify return logic

2019-12-23 Thread Kevin Ottens
ervin added a comment. In D26130#582465 , @patrickelectric wrote: > In D26130#582447 , @ervin wrote: > > > In D26130#582391 , @tcanabrava wrote: > > >

D26130: Simplify return logic

2019-12-23 Thread patrick j pereira
patrickelectric added a comment. In D26130#582447 , @ervin wrote: > In D26130#582391 , @tcanabrava wrote: > > > In D26130#582343 , @ervin wrote: > > >

D26130: Simplify return logic

2019-12-23 Thread Kevin Ottens
ervin added a comment. In D26130#582391 , @tcanabrava wrote: > In D26130#582343 , @ervin wrote: > > > This is pointless, most compilers would do NRVO (+ move assign) here... which would be neatly ob

D26130: Simplify return logic

2019-12-23 Thread Tomaz Canabrava
tcanabrava added a comment. In D26130#582343 , @ervin wrote: > This is pointless, most compilers would do NRVO (+ move assign) here... which would be neatly obliterated by the ternary operator. This is a pessimisation you're proposing here, not

D26130: Simplify return logic

2019-12-23 Thread Kevin Ottens
ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. This is pointless, most compilers would do NRVO (+ move assign) here... which would be neatly obliterated by the ternary operator. This is a pessimisation you're proposing here, not

D26130: Simplify return logic

2019-12-20 Thread patrick j pereira
patrickelectric accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH simplifyVarPath REVISION DETAIL https://phabricator.kde.org/D26130 To: tcanabrava, patrickelectric Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26130: Simplify return logic

2019-12-20 Thread Tomaz Canabrava
tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Don't create a temporary to edit and return, return something directly, this way we can benefit from RTO TEST