D26118: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26118#608935 , @broulik wrote: > This appears to have broken policy file generation. The polkit files I now get have > > Neues Plymouth-Design installieren > > > Note the "Name" in the `xml:lang`

D26118: Port QRegExp to QRegularExpression

broulik added a comment. This appears to have broken policy file generation. The polkit files I now get have Neues Plymouth-Design installieren Note the "Name" in the `xml:lang` REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #framew

D26118: Port QRegExp to QRegularExpression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R283:b2975d8e630c: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R283 KAuth CHANGES SINCE LAST

D26118: Port QRegExp to QRegularExpression

dfaure accepted this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir added reviewers: dfaure, apol. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72039. ahmadsamir added a comment. QRegularExpression is an object like any other, make it const as need be. REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26118?vs=71948&id=72039 BRANCH l-qregularexpression (branch

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71948. ahmadsamir added a comment. KF5 now requires Qt 5.12 REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26118?vs=71884&id=71948 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabri

D26118: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71884. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Don't touch Qt required version directly for frameworks. Use \A and \z anchors instead of the convenience function QRegularExpression::anchoredPattern() REPOSITORY R

D26118: Port QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:14 > kauth is a framework package. You can't increase qt version directly. I didn't know that, sorry. Luckily fixing it is easy in this particular case, I'll anchor

D26118: Port QRegExp to QRegularExpression

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:14 > > -set(REQUIRED_QT_VERSION 5.11.0) > +set(REQUIRED_QT_VERSION 5.12.0) > find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus

D26118: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Require Qt 5.12 for QRegularExpression::anchoredPattern() TEST PLAN make && ctest REPOSITORY R283 KAuth BR