D26099: Port QRegExp to QRegularExpression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R293:eec35486c419: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R293 Baloo CHANGES SINCE LAST

D26099: Port QRegExp to QRegularExpression

dfaure accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent, apol, dfaure Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, as

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 73367. ahmadsamir added a comment. - Rebase\n- Move second match inside if condition, otherwise the control flow never passes through the next else if branch REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=720

D26099: Port QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > timelinetools.cpp:122 > +} else if (sections.count() > 1) { > +match = s_dateRegexp.match(sections[sections.count() - 2]); > +i

D26099: Port QRegExp to QRegularExpression

ahmadsamir added reviewers: apol, dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent, apol, dfaure Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, m

D26099: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich

D26099: Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, asha

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72040. ahmadsamir added a comment. Use const REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71992&id=72040 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D26099 AFFE

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71992. ahmadsamir added a comment. Link to KF6 task REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71954&id=71992 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator.kde.org/D2609

D26099: Port QRegExp to QRegularExpression

ahmadsamir marked an inline comment as done. ahmadsamir added a comment. I guess I was confused because I saw KItemModels has the min. Qt version 5.12.0 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc:

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71954. ahmadsamir added a comment. Don't assign inside if condition REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71943&id=71954 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricat

D26099: Port QRegExp to QRegularExpression

bruns added inline comments. INLINE COMMENTS > timelinetools.cpp:119 > +QRegularExpressionMatch match; > +if ((match = s_dateRegexp.match(sections.last())).hasMatch()) { > dateString = sections.last(); Pleae avoid assigning in an `if (...)` expression, just move it t

D26099: Port QRegExp to QRegularExpression

meven accepted this revision. meven added a comment. Seems fine to me REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson

D26099: Port QRegExp to QRegularExpression

meven added a comment. In D26099#581001 , @ahmadsamir wrote: > Frameworks now require Qt 5.12 Indeed since 65da5bf151fa934bbdcac82543e3cd9f5cc4ab43 in baloo RE

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71943. ahmadsamir added a comment. Frameworks now require Qt 5.12 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71936&id=71943 BRANCH l-qregexp (branched from master) REVISION DETAIL https://phabricator

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71936. ahmadsamir added a comment. Add TODO for when we can depend on Qt 5.12 REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71888&id=71936 BRANCH l-qregexp (branched from master) REVISION DETAIL https:/

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71888. ahmadsamir removed a subscriber: mlaurent. ahmadsamir added a comment. Revert min required Qt version REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71869&id=71888 BRANCH l-qregexp (branched from mas

D26099: Port QRegExp to QRegularExpression

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:3 > cmake_minimum_required(VERSION 3.5) > -set(REQUIRED_QT_VERSION 5.11.0) > +set(REQUIRED_QT_VERSION 5.12.0) > set(KF5_VERSION "5.66.0")

D26099: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 71869. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Use QRegularExpression::anchoredPattern() to port QRegExp::exactMatch() REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26099?vs=71832&i

D26099: Port QRegExp to QRegularExpression

ahmadsamir planned changes to this revision. ahmadsamir added a comment. I messed up exactMatch stuff, will have to rethink it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich Cc: kde-frameworks-devel, hurikhan77, l

D26099: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Baloo, meven, bruns, astippich. Herald added projects: Frameworks, Baloo. ahmadsamir requested review of this revision. TEST PLAN The code builds and unit tests pass. REPOSITORY R293 Baloo BRANCH l-qregexp (branched from master)