aacid added a comment.
Thanks for taking care of it, i was busy yesterday with pre-xmas stuff
REPOSITORY
R270 KCodecs
REVISION DETAIL
https://phabricator.kde.org/D25974
To: aacid, dfaure
Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
dfaure added a comment.
Fixed in
https://commits.kde.org/kcodecs/6fcd8af5b4be2082c4af7d11c18d39151f1e25d0
REPOSITORY
R270 KCodecs
REVISION DETAIL
https://phabricator.kde.org/D25974
To: aacid, dfaure
Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, br
dfaure added inline comments.
INLINE COMMENTS
> nsCodingStateMachine.h:71
> + mModel->stateTable);
> +if (nextCurrentState < eStart || nextCurrentState > eItsMe) {
> +mCurrentState = eError;
eStart is 0 and GETFROMPCK retur
dfaure added a comment.
This change breaks a unittest
* Start testing of KEncodingProberTest *
Config: Using QtTest library 5.14.0, Qt 5.14.0 (x86_64-little_endian-lp64
shared (dynamic) debug build; by GCC 7.4.1 20190905 [gcc-7-branch revision
275407])
PASS :
This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R270:a890441e38ee: Fix Invalid-enum-value assignment (authored
by aacid).
CHANGED PRIOR TO COMMIT
https://phabricator.k
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Looks good otherwise.
INLINE COMMENTS
> nsCodingStateMachine.h:74
> +} else {
> +mCurrentState = (nsSMState)nextCurrentState;
> +}
Please use static_c
aacid added a subscriber: security-team.
REPOSITORY
R270 KCodecs
REVISION DETAIL
https://phabricator.kde.org/D25974
To: aacid
Cc: security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
It is undefined behaviour
oss-fuzz/19481
REPOSITORY
R270 KCodecs
BRANCH
master
REVISION DETAIL
https://phabric
