D25922: Don't use a verified nullptr as a data source

2019-12-15 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R235:5a379ba5a6ce: Don't use a verified nullptr as a data source (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25922?vs=71362&id=71608 REVISION DE

D25922: Don't use a verified nullptr as a data source

2019-12-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH dont-use-null-qcoreapp-instance (branched from master) REVISION DETAIL https://phabricator.kde.org/D25922 To: leinir, #frameworks, #knewstuff, #plasma, ronaldv, apol Cc: kde-framewo

D25922: Don't use a verified nullptr as a data source

2019-12-12 Thread Dan Leinir Turthra Jensen
leinir added reviewers: Frameworks, KNewStuff, Plasma, ronaldv. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D25922 To: leinir, #frameworks, #knewstuff, #plasma, ronaldv Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25922: Don't use a verified nullptr as a data source

2019-12-12 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Actually use some variables with usable information in version.h Don't de-reference what will at this point definitel