This revision was automatically updated to reflect the committed changes.
Closed by commit R304:709944d6cb5c: Support archive installs with adoption
commands (authored by leinir).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25824?vs=71173&id=71185
REVISI
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R304 KNewStuff
BRANCH
support-archive-installs-in-use-commands (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25824
To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham
Cc:
leinir updated this revision to Diff 71173.
leinir marked an inline comment as done.
leinir added a comment.
- Ensure rootPath is definitely clean and has a / at the end
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25824?vs=71134&id=71173
BRANCH
supp
leinir marked an inline comment as done.
leinir added inline comments.
INLINE COMMENTS
> apol wrote in engine.cpp:744
> Shouldn't we make sure rootPath ends with /?
> at least with an ASSERT if we know it's there.
Hmm... It /should/ be done, but it's also not a bad thing to perform a touch of
s
apol added inline comments.
INLINE COMMENTS
> engine.cpp:744
> +const QDir dir(currentPath);
> if (dir.path()==(rootPath+dir.dirName())) {
> +qCDebug(KNEWSTUFFCORE) << "Found directory" << dir;
Shouldn't we make sure rootPath ends with /?
at least with an ASSERT if w
leinir edited the test plan for this revision.
leinir added reviewers: Frameworks, Plasma, KNewStuff, apol, ngraham.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D25824
To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, G
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
This previously caused any icon pack installed through the store to
not function when the adoption command pointed at a
