D25798: Deprecated allowAsDefault

ngraham added a comment. Thanks! REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25798 To: nicolasfella, #frameworks, dfaure Cc: ngraham, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25798: Deprecated allowAsDefault

dfaure added a comment. Removed: https://commits.kde.org/kde-cli-tools/e435a827bba9ebfbe7f988fe063b5848f5ff524b (also merged to master) It's not an actual use case for the feature when zero desktop file sets this field :) REPOSITORY R309 KService REVISION DETAIL https://phabricat

D25798: Deprecated allowAsDefault

ngraham added a comment. This makes `kde-cli-tools` fail to build for me with Qt 5.14 on openSUSE Tumbleweed: [ 43%] Linking CXX executable ../bin/kioclient5 /home/nate/kde/src/kde-cli-tools/keditfiletype/mimetypedata.cpp: In member function ‘QStringList MimeTypeData::getAppOffers(

D25798: Deprecated allowAsDefault

This revision was automatically updated to reflect the committed changes. Closed by commit R309:f45bfd1c9fc0: Deprecated allowAsDefault (authored by nicolasfella). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25798?vs=73672&id=74282 REVISION DETAIL https

D25798: Deprecated allowAsDefault

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH allo REVISION DETAIL https://phabricator.kde.org/D25798 To: nicolasfella, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25798: Deprecated allowAsDefault

nicolasfella added a reviewer: dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25798 To: nicolasfella, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25798: Deprecated allowAsDefault

nicolasfella updated this revision to Diff 73672. nicolasfella added a comment. - Fix and update REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25798?vs=71036&id=73672 BRANCH allo REVISION DETAIL https://phabricator.kde.org/D25798 AFFECTED FILES s

D25798: Deprecated allowAsDefault

kossebau added inline comments. INLINE COMMENTS > kservice.cpp:982 > > +#if KSERVICE_ENABLE_DEPRECATED_SINCE(5, 65) > bool KService::allowAsDefault() const This should be BUILD, not ENABLE. *BUILD* macros are controlled by the EXCLUDE_DEPRECATED_BEFORE_AND_AT value, which iis what is used a

D25798: Deprecated allowAsDefault

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Execute upon T12309 . The KServ