D25660: Decouple KBookmarksMenu from KActionCollection

mlaurent added a comment. In D25660#635693 , @dfaure wrote: > @mlaurent AFAICS you removed the deprecation macro completely in master, and left it (with 0x06) in release/20.04? nope or I missed to forward port in 20.04. So it's an err

D25660: Decouple KBookmarksMenu from KActionCollection

kossebau added a comment. Just as reminder: When keeping the use of the macro flags, make sure to - also set the `*_DEPRECATED_WARNINGS_SINCE` flags to 0x06, otherwise deprecation warnings for newer API will no longer be shown, due to default set by `*_DISABLE_DEPRECATED_BEFORE*`

D25660: Decouple KBookmarksMenu from KActionCollection

dfaure added a subscriber: mlaurent. dfaure added a comment. @mlaurent AFAICS you removed the deprecation macro completely in master, and left it (with 0x06) in release/20.04? I thought we wanted - to remove it in release/20.04 (or set it to a tested value like 0x053A00) - to s

D25660: Decouple KBookmarksMenu from KActionCollection

kossebau added a comment. In D25660#635658 , @bcooksley wrote: > Thanks. That macro really does cause quite a bit of trouble... It is not the macro, but using it with a future version of 0x06. See https://marc.info/?l=kde-devel&m

D25660: Decouple KBookmarksMenu from KActionCollection

bcooksley added a comment. Thanks. That macro really does cause quite a bit of trouble... REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks, dfaure Cc: bcooksley, kossebau, dfaure, apol, kde-frameworks-devel, LeGast00n, cblack, G

D25660: Decouple KBookmarksMenu from KActionCollection

dfaure added a comment. As usual, it's the too strong "no deprecated API usage" define in the apps. Fixed. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks, dfaure Cc: bcooksley, kossebau, dfaure, apol, kde-frameworks-devel,

D25660: Decouple KBookmarksMenu from KActionCollection

bcooksley added a comment. Could this commit be the cause of https://build.kde.org/job/Applications/job/krdc/job/stable-kf5-qt5%20FreeBSDQt5.14/3/consoleText (ie. this commit is SIC?) REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #fram

D25660: Decouple KBookmarksMenu from KActionCollection

This revision was automatically updated to reflect the committed changes. Closed by commit R294:0c888e2f8098: Decouple KBookmarksMenu from KActionCollection (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25660?vs=73666&id=78402#toc REPOSITORY R294 KBookmarks

D25660: Decouple KBookmarksMenu from KActionCollection

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Oops I forgot to review this again after your last changes. Looks fine to me now, but meanwhile it needs s/5.67/5.69/ everywhere (docu and deprecation macros). Feel free to land if yo

D25660: Decouple KBookmarksMenu from KActionCollection

nicolasfella updated this revision to Diff 73666. nicolasfella marked 11 inline comments as done. nicolasfella added a comment. - Decouple from KActionCollection - Set action name - Restore root check - Use constructor delegation - Update since - fix docs - Docs fixes - Use QStrin

D25660: Decouple KBookmarksMenu from KActionCollection

kossebau added a comment. Some API (docs) nitpicks :) INLINE COMMENTS > kbookmarkmenu.cpp:88 > +m_parentMenu(_parentMenu), > +m_parentAddress(QLatin1String("")) //TODO KBookmarkAdress::root > +{ Why the `QLatin1String("")` instead of QString()? Is there a need for a non-null empty

D25660: Decouple KBookmarksMenu from KActionCollection

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for the patch. Please call setObjectName() on the actions so that their object name is fixed (no matter which ctor is used). (this is because KActionCollection::addAct

D25660: Decouple KBookmarksMenu from KActionCollection

nicolasfella updated this revision to Diff 70694. nicolasfella added a comment. Rebase REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25660?vs=70693&id=70694 BRANCH addd REVISION DETAIL https://phabricator.kde.org/D25660 AFFECTED FILES src/kbo

D25660: Decouple KBookmarksMenu from KActionCollection

nicolasfella retitled this revision from "Add member for editbookmarks action" to "Decouple KBookmarksMenu from KActionCollection". nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabri