D25638: autotests: Find perl executable on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R172:accdbdd65ee0: autotests: Find perl executable on all platforms (authored by aspotashev). REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25638?vs=70636&id=706

D25638: autotests: Find perl executable on all platforms

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I approve, given that I wrote the same in D25643 :-) REPOSITORY R172 KCalendar Core BRANCH perl REVISION DETAIL https://phabricator.kde.org/D256

D25638: autotests: Find perl executable on all platforms

aspotashev added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:93 > maybe it would make sense to check for BSD instead? > I don't know much about BSD, but I'd expect the shebang to work there as well. I think it's better to minimize platform-specific if-endifs and make CMake co

D25638: autotests: Find perl executable on all platforms

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:93 > - set(_runner ${CMAKE_CURRENT_SOURCE_DIR}/runsingletestcase.pl) > - if(WIN32) > -set(_runner ${PERL_EXECUTABLE} ${_runner}) maybe it would make sense to check for BSD instead? I don't know much about BSD, but I'd expect the

D25638: autotests: Find perl executable on all platforms

aspotashev added a reviewer: Frameworks. aspotashev added a project: Frameworks. aspotashev added a subscriber: Frameworks. REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D25638 To: aspotashev, #frameworks Cc: #frameworks, kde-pim, bcooksley, LeGast00n, fbampalouk