This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6973d4b26501: Deprecate KFileWidget::toolBar (authored by
nicolasfella).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D25533?vs=70622&id=71631#toc
REPOSITORY
R241 KIO
CHANGES SINCE LAST UP
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
This patch itself is still correct though, of course.
REPOSITORY
R241 KIO
BRANCH
ktoolbar
REVISION DETAIL
https://phabricator.kde.org/D25533
To: nicolasfella, #frameworks, dfaure
Cc
dfaure added a comment.
I started a kdesrc-build with the method removed, and found that
KFileDialog::toolBar (in kdelibs4support) uses it, so it needs a matching #if
in case EXCLUDE_DEPRECATED_BEFORE_AND_AT.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25533
To: ni
nicolasfella updated this revision to Diff 70622.
nicolasfella added a comment.
- Adjust version
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25533?vs=70317&id=70622
BRANCH
ktoolbar
REVISION DETAIL
https://phabricator.kde.org/D25533
AFFECTED FILES
sr
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
5.65 isn't released yet, you can use 5.65 as deprecation version here.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25533
To: nicolasfella, #frameworks, d
nicolasfella added a task: T12206: Port KFileWidget away from KToolBar.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25533
To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
It leaks KToolBar from KXmlGui into the public API. I did no
