ngraham edited the test plan for this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D25444
To: ngraham, #frameworks, cfeck, mart
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ngraham updated this revision to Diff 70128.
ngraham added a comment.
Do it universally
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25444?vs=70118&id=70128
BRANCH
fix-assistant-dialog-margins (branched from master)
REVISION DETAIL
https://ph
ngraham planned changes to this revision.
ngraham added a comment.
Sure, I can look into that.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D25444
To: ngraham, #frameworks, cfeck, mart
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, b
cfeck added a comment.
Since KAssistantDialog is a KPageDialog, what happens to other users of that
class? I had hoped the fix is in KPageDialog, and it would only omit the
margins when the caller requested it (e.g. KCMs etc.).
INLINE COMMENTS
> kassistantdialog.cpp:103
> +q->pageWidget
ngraham updated this revision to Diff 70118.
ngraham marked an inline comment as done.
ngraham added a comment.
Cache the style
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25444?vs=70115&id=70118
BRANCH
fix-assistant-dialog-margins (branched fr
kossebau added inline comments.
INLINE COMMENTS
> kassistantdialog.cpp:102
> +q->pageWidget()->layout()->setContentsMargins(
> +q->pageWidget()->style()->pixelMetric(QStyle::PM_LayoutLeftMargin),
> +q->pageWidget()->style()->pixelMetric(QStyle::PM_LayoutTopMargin),
Ideally q
ngraham created this revision.
ngraham added reviewers: Frameworks, cfeck, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Same fix as in
https://commits.kde.org/kcmutils/377a27db91e80aa01fdc6
